Block Bindings: Remove unneeded 'setAttributes' override #58806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -32 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Feb 8, 2024
| @@ -36,8 +36,7 @@ const createEditFunctionWithBindingsAttribute = () => | |||
| const { getBlockBindingsSource } = unlock( | |||
| useSelect( blockEditorStore ) | |||
| ); | |||
| const { getBlockAttributes, updateBlockAttributes } = | |||
| useSelect( blockEditorStore ); | |||
| const { getBlockAttributes } = useSelect( blockEditorStore ); | |||
|
|
|||
| const updatedAttributes = getBlockAttributes( clientId ); | |||
There was a problem hiding this comment.
Why are we calling a selector during render here? Btw I think we have access to the attributes through props.attributes, so we can shallow clone that?
There was a problem hiding this comment.
Btw down below we are mutating the attributes object directly in the store? 🤔
updatedAttributes[ attributeName ] =
There was a problem hiding this comment.
Good point.
We can make a few more improvements here, but I'm not familiar enough with the future to confidently make them. So, I decided to stick with changes that won't affect anything.
Suggested improvements:
- No need to use
useBlockEditContext. All required data should be available viaprops. - Clone attributes from
props.attributes. - Return early if there are no bindings.
There was a problem hiding this comment.
Thanks for sharing the feedback! Actually, I wanted to review that part because in a recent experiment I realized it could be improved as you suggest: link. There, I'm getting the data via props and mutating the attributes in a different way.
Do you think that approach would be better?
There was a problem hiding this comment.
Sweet! Can you share the PR link? We can continue our discussion there.
There was a problem hiding this comment.
Sorry I forgot that! Here is the PR: link.
It is just an initial experiment that hasn't been tested and needs to be improved. I was considering reusing just the attributesWithBindings part and creating another pull request only with that if we consider it better than the current approach.
SantosGuillamot
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Thanks for the PR! I believe we can merge this one and address this feedback in a follow-up because I think it is not related to these changes but to the original implementation.
|
Sounds good, @SantosGuillamot! |
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes unnecessary (for the moment)
setAttributesoverride for Block Bindings API.Why?
See #58085 (comment).
Testing Instructions
Use testing instructions - #58085.